This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix change to fgMorphBlockOperand #15814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BruceForstall @dotnet/jit-contrib PTAL |
BruceForstall
approved these changes
Jan 10, 2018
src/jit/morph.cpp
Outdated
| #ifndef LEGACY_BACKEND | ||
| effectiveVal = lclNode; | ||
| needsIndirection = false; | ||
| JITDUMP("Replacing block node with lclVar"); |
There was a problem hiding this comment.
nit: the JITDUMP needs a trailing newline \n
My recent fix broke the `DYN_BLK` case. In addition to checking that types match, we *still* need to check that the sizes match. This was caught by desktop testing. The test cases are somewhat complex, so I created a smaller repro.
|
The previous fix was PR #15726 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My recent fix broke the
DYN_BLKcase. In addition to checking that types match, we still need to check that the sizes match.This was caught by desktop testing. The test cases are somewhat complex, so I created a smaller repro.