This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[release/2.2] Remove the Smarty dependency and move Windows ARM to Helix queue #20613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lix queue Port (partially) the following changes: * Build xunit wrappers the same way on windows and unix (#18695) * Work around cmd command length limit in xunit Exec task (#19095) * Update vc-runtime package to support ARM and ARM64 with current builds (#19265) * build-test - fix TestWrapper CS warnings (#19180) * Clean up build.cmd/build-test.cmd/runtest.cmd (#19291) * Use runtest.py to run tests for all platforms (#19213) * Updating runtest.py so that it works with Python 3 (#19768) * Fix build-test.sh wrapper build (#19779) * Move ARM64 Windows boxen to be Helix-provisioned (#20204) * Runtest.py on Windows Arm(64) (#20227) * Use runtest.cmd for arm(64) windows testing (#20301) * Do not restore or initialize buildtools for x86/arm64 (#20370) * Add hack for arm64/x86 to skip build tools restore (#20390) Update Xunit to 2.4.1 prerelease version Use the latest version (dbf0bf1) of tests/runtest.py
echesakov
requested review from
sbomer,
jashook,
BruceForstall and
RussKeldorph
sbomer
approved these changes
Oct 25, 2018
RussKeldorph
added
the
Servicing-consider
|
Approved for 2.2 |
vivmishra
added
Servicing-approved
BruceForstall
approved these changes
Oct 25, 2018
|
@dotnet-bot test Ubuntu arm Cross Checked Innerloop Build and Test |
|
All the CI changes tested in dev/unix_test_workflow branch (#20576) Official build tested in https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/results?buildId=2154949 Ubuntu arm64 Cross Debug Innerloop Build failure also observed in #20615 so gonna ignore this |
|
@dotnet-bot test ci |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Port (partially) the following changes to enable Win/ARM testing in release/2.2:
Update Xunit to 2.4.1 prerelease version
Use the latest version (dbf0bf1) of tests/runtest.py
Customer impact
Allow us to get ARM bugs out of the product more easily.
Regression?
No
Packaging reviewed?
N/A
Risk
Low to product. Moderate to infra. This is a large change, though it's mostly just a port of several changes that have been in master for a while.