Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

string.EndsWith use SequenceEqual not SequenceCompareTo #22207

Merged
merged 5 commits into from
Jan 28, 2019
Merged

string.EndsWith use SequenceEqual not SequenceCompareTo #22207

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
df1c555
string.EndsWithUse SequenceEqual not SequenceCompareTo
benaadams Jan 25, 2019
3c2da67
Use Span.SequenceEqual
benaadams Jan 25, 2019
b4b37b1
Check length prior to subtract
benaadams Jan 25, 2019
06004e0
feedback
benaadams Jan 25, 2019
04b10d2
Sorta
benaadams Jan 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/System.Private.CoreLib/shared/System/String.Comparison.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,8 @@ public bool EndsWith(string value, StringComparison comparisonType)
return CompareInfo.Invariant.IsSuffix(this, value, GetCaseCompareOfComparisonCulture(comparisonType));

case StringComparison.Ordinal:
return this.Length < value.Length ? false : (CompareOrdinalHelper(this, this.Length - value.Length, value.Length, value, 0, value.Length) == 0);
int offset = this.Length - value.Length;
return (uint)offset <= (uint)this.Length && this.AsSpan(offset).SequenceEqual(value);

case StringComparison.OrdinalIgnoreCase:
return this.Length < value.Length ? false : (CompareInfo.CompareOrdinalIgnoreCase(this, this.Length - value.Length, value.Length, value, 0, value.Length) == 0);
Expand Down