This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Disable a couple of S.R.InteropServices tests #23697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kouvel
commented
Apr 3, 2019
kouvel
commented
- It looks like these are running in outdated snapshots:
- https://ci.dot.net/job/dotnet_coreclr/job/master/job/x64_checked_ubuntu_corefx_innerloop_prtest/9973/
- https://ci.dot.net/job/dotnet_coreclr/job/master/job/x64_checked_ubuntu_corefx_innerloop_prtest/10012/
- Disabled the two tests that were fixed in PR Handle the case where the Marshal.ThrowExceptionForHR is inlined in corefx#34968 to get CI clean
jkoritzinsky
approved these changes
Apr 3, 2019
|
@kouvel Can't we just update CoreFX? I don't see why we need to disable these tests right now. That PR is from late January. |
|
I guess it's a temporary measure until the CoreFX testing from CoreCLR repo can be migrated, see #23599 (comment). |
AaronRobinsonMSFT
approved these changes
Apr 4, 2019
AaronRobinsonMSFT
added
the
disabled-test
|
@kouvel can we get this merged in? CoreFX test runs aren't running clean without it. |
- It looks like these are running in outdated snapshots: - https://ci.dot.net/job/dotnet_coreclr/job/master/job/x64_checked_ubuntu_corefx_innerloop_prtest/9973/ - https://ci.dot.net/job/dotnet_coreclr/job/master/job/x64_checked_ubuntu_corefx_innerloop_prtest/10012/ - Disabled the two tests that were fixed in PR dotnet/corefx#34968
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Disabled the two tests that were fixed in PR dotnet/corefx#34968 Commit migrated from dotnet/coreclr@8deef30
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.