Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
4eb8e34
Array exceptions to ThrowHelper
benaadams Aug 5, 2016
e74d07c
CommonlyUsedGenericInstantiations -> NoOptimization
benaadams Aug 6, 2016
ea19ac1
Task<T> exceptions to ThrowHelper
benaadams Aug 7, 2016
92621bc
Lazy<T> exceptions to ThrowHelper
benaadams Aug 7, 2016
5d14821
Progress<T> exceptions to ThrowHelper
benaadams Aug 7, 2016
c90052f
WeakReference<T> exceptions to ThrowHelper
benaadams Aug 7, 2016
532c968
ConcurrentDictionary<TKey, TValue> exceptions to ThrowHelper
benaadams Aug 8, 2016
cda4eab
ConcurrentQueue<T> exceptions to ThrowHelper
benaadams Aug 8, 2016
1ec0c03
ConcurrentStack<T> exceptions to ThrowHelper
benaadams Aug 8, 2016
104e30a
OrderablePartitioner<TSource> exceptions to ThrowHelper
benaadams Aug 8, 2016
13d362d
Partitioner<TSource> exceptions to ThrowHelper
benaadams Aug 8, 2016
ecc3b36
OrderablePartitioner<T> exceptions to ThrowHelper
benaadams Aug 8, 2016
37b40d3
Remove ResId (exceptions to ThrowHelper)
benaadams Aug 8, 2016
b5e1faa
ArraySortHelper<T> exceptions to ThrowHelper
benaadams Aug 8, 2016
683d577
Comparer<T> exceptions to ThrowHelper
benaadams Aug 8, 2016
5c31d81
EqualityComparer<T> exceptions to ThrowHelper
benaadams Aug 8, 2016
028cb08
ReadOnlyDictionary<TKey, TValue> exceptions to ThrowHelper
benaadams Aug 8, 2016
ec7b06d
Task<T> exceptions to ThrowHelper
benaadams Aug 8, 2016
b09a4c7
Task.XXX<TResult> exceptions to ThrowHelper
benaadams Aug 8, 2016
8e2945f
TaskCompletionSource<TResult> exceptions to ThrowHelper
benaadams Aug 8, 2016
f1b6095
Improve enum check
benaadams Aug 10, 2016
2617a3b
No-return throwhelpers, reuse specific ones
benaadams Aug 14, 2016
127e9e8
Collapse Non Nullable type exception
benaadams Aug 14, 2016
ce291b4
Prevent ngen Array.Sort short circuit
benaadams Aug 15, 2016
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/mscorlib/model.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9505,7 +9505,6 @@
<Member Status="ApiRoot" Name="Invoke(System.Type,System.Object)" />
</Type>
<Type Status="ImplRoot" Name="System.ReflectionOnlyType" />
<Type Status="ImplRoot" Name="System.ResId" />
<Type Status="ImplRoot" Name="System.Resolver">
<Member Name="GetJitContext(System.Int32@)" /> <!-- EE -->
<Member Name="GetCodeInfo(System.Int32@,System.Int32@,System.Int32@)" /> <!-- EE -->
Expand Down
1 change: 0 additions & 1 deletion src/mscorlib/mscorlib.shared.sources.props
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,6 @@
<SystemSources Include="$(BclSourcesRoot)\System\Progress.cs" />
<SystemSources Include="$(BclSourcesRoot)\System\Random.cs" />
<SystemSources Include="$(BclSourcesRoot)\System\RankException.cs" />
<SystemSources Include="$(BclSourcesRoot)\System\ResId.cs" />
<SystemSources Include="$(BclSourcesRoot)\System\RtType.cs" />
<SystemSources Include="$(BclSourcesRoot)\System\RuntimeArgumentHandle.cs" />
<SystemSources Include="$(BclSourcesRoot)\System\RuntimeHandles.cs" />
Expand Down
18 changes: 9 additions & 9 deletions src/mscorlib/src/System/AppDomain.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2834,7 +2834,7 @@ internal static void Resume()
#endif

private AppDomain() {
throw new NotSupportedException(Environment.GetResourceString(ResId.NotSupported_Constructor));
ThrowHelper.ThrowNotSupportedException(ExceptionResource.NotSupported_Constructor);
}

[System.Security.SecuritySafeCritical] // auto-generated
Expand Down Expand Up @@ -4559,7 +4559,7 @@ public TimeSpan MonitoringTotalProcessorTime
Int64 i64ProcessorTime = nGetTotalProcessorTime();
if (i64ProcessorTime == -1)
{
throw new InvalidOperationException(Environment.GetResourceString("InvalidOperation_WithoutARM"));
ThrowHelper.ThrowInvalidOperationException(ExceptionResource.InvalidOperation_WithoutARM);
}
return new TimeSpan(i64ProcessorTime);
}
Expand All @@ -4575,7 +4575,7 @@ public Int64 MonitoringTotalAllocatedMemorySize
Int64 i64AllocatedMemory = nGetTotalAllocatedMemorySize();
if (i64AllocatedMemory == -1)
{
throw new InvalidOperationException(Environment.GetResourceString("InvalidOperation_WithoutARM"));
ThrowHelper.ThrowInvalidOperationException(ExceptionResource.InvalidOperation_WithoutARM);
}
return i64AllocatedMemory;
}
Expand All @@ -4593,7 +4593,7 @@ public Int64 MonitoringSurvivedMemorySize
Int64 i64LastSurvivedMemory = nGetLastSurvivedMemorySize();
if (i64LastSurvivedMemory == -1)
{
throw new InvalidOperationException(Environment.GetResourceString("InvalidOperation_WithoutARM"));
ThrowHelper.ThrowInvalidOperationException(ExceptionResource.InvalidOperation_WithoutARM);
}
return i64LastSurvivedMemory;
}
Expand All @@ -4613,7 +4613,7 @@ public static Int64 MonitoringSurvivedProcessMemorySize
Int64 i64LastSurvivedProcessMemory = nGetLastSurvivedProcessMemorySize();
if (i64LastSurvivedProcessMemory == -1)
{
throw new InvalidOperationException(Environment.GetResourceString("InvalidOperation_WithoutARM"));
ThrowHelper.ThrowInvalidOperationException(ExceptionResource.InvalidOperation_WithoutARM);
}
return i64LastSurvivedProcessMemory;
}
Expand All @@ -4630,24 +4630,24 @@ public static Int64 MonitoringSurvivedProcessMemorySize

void _AppDomain.GetTypeInfoCount(out uint pcTInfo)
{
throw new NotImplementedException();
ThrowHelper.ThrowNotImplementedException();
}

void _AppDomain.GetTypeInfo(uint iTInfo, uint lcid, IntPtr ppTInfo)
{
throw new NotImplementedException();
ThrowHelper.ThrowNotImplementedException();
}

void _AppDomain.GetIDsOfNames([In] ref Guid riid, IntPtr rgszNames, uint cNames, uint lcid, IntPtr rgDispId)
{
throw new NotImplementedException();
ThrowHelper.ThrowNotImplementedException();
}

// If you implement this method, make sure to include _AppDomain.Invoke in VM\DangerousAPIs.h and
// include _AppDomain in SystemDomain::IsReflectionInvocationMethod in AppDomain.cpp.
void _AppDomain.Invoke(uint dispIdMember, [In] ref Guid riid, uint lcid, short wFlags, IntPtr pDispParams, IntPtr pVarResult, IntPtr pExcepInfo, IntPtr puArgErr)
{
throw new NotImplementedException();
ThrowHelper.ThrowNotImplementedException();
}
#endif
}
Expand Down
Loading