Resolve unblocked TODOs and formatting changes to System.Net.Mail.

[Priya91]

Address PR comments left by @CIPop

Also addresses TODO with issue #11747

cc @CIPop @stephentoub

[stephentoub]

EmailEventSource => MailEventSource?

[Priya91]

Oki, will rename.

[stephentoub]

In the past I believe @vancem's guidance has been to not explicitly specify a Guid, and to not worry about localizing resources.

[vancem]

Definitely drop the Guid specification. If you do not the only way to turn this EventSource on is by Guid (you can't use its name).

    /// Overrides the default (calculated) Guid of an EventSource type. **Explicitly defining a GUID is discouraged**, 
    /// except when upgrading existing ETW providers to using event sources.

Localization of resource is only useful if you have an EXPLICT scenario where you are using this EventSource to send message to the Windows Event Log (the only logger that uses it). This is also a very specialized use case, so in general we recommend against, it but unlike the GUID issue it does not explicitly 'hurt' (it just adds unnecessary complexity).

[davidsh]

Even we chose not to localize the resources, we place all strings in the resource file anyways. This is better than putting hard-coded strings in the *.CS files themselves.

So, I would prefer we keep this design as-is and leave strings in the resources file.

[Priya91]

I didn't add GUID initially for the reasons stated above, found an article about it on msdn blog. @CIPop left feedback on the merged PR #12416 to explicitly add a GUID and update windows debugging documentation, the discussion is here

cc @CIPop Are you ok with reverting this change or keeping the GUID?

[vancem]

Note that removing the Guid parameter does NOT mean that the EventSource does not have a GUID, it only means that the EventSource generates it from the name. In fact the GUID that it will have for the name Microsoft-System-Net-Mail will be
42c8027b-f048-58d2-537d-a4a9d5ee7038
However you can also use *Microsoft-System-Net-Mail in most tools instead (which is MUCH nicer).

[davidsh]

However you can also use *Microsoft-System-Net-Mail in most tools

What about tools where you have to specify the GUID?

And we already have GUIDs for other event sources. See:
Documentation/debugging/windows-instructions.md

[Priya91]

Will remove the GUID for now, @CIPop please file issue if you disagree. Thanks!

[CIPop]

@Priya91 @vancem

It's fine to remove the GUID but add it within both the source code as well as https://github.com/dotnet/corefx/blob/master/Documentation/debugging/windows-instructions.md#traces

However you can also use *Microsoft-System-Net-Mail in most tools instead (which is MUCH nicer).

I found this doesn't work logman.
@vancem please review https://github.com/dotnet/corefx/blob/master/Documentation/debugging/windows-instructions.md#traces and let me know if there is a way to use the *<name> format using existing Windows tools.

[CIPop]

Tracking with #12808.

[CIPop]

Thanks @Priya91 ! Really appreciate seeing the nitpick fixed as well!