This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Make well-known IPv4 addresses readonly #33531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use approach suggested in #33476
stephentoub
reviewed
Nov 15, 2018
alfredmyers
reviewed
Nov 15, 2018
|
@dotnet-bot test Outerloop Windows x64 Debug Build |
bartonjs
approved these changes
Nov 15, 2018
|
As far as I can see, the build failures do not seem related to this change. Happy to address any remaining issues if I'm wrong about this. |
|
@dotnet-bot test Outerloop Windows x64 Debug Build |
|
@dotnet-bot test UWP CoreCLR x64 Debug Build |
|
None of these failures are associated with this change. Thanks for the fix. |
jlennox
pushed a commit
to jlennox/corefx
that referenced
this pull request
Dec 16, 2018
* Fix https://github.com/dotnet/corefx/issues/33373 Use approach suggested in dotnet#33476 * Skip tests for IPAddress.Address setter throwing on .NET Framework
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Fix https://github.com/dotnet/corefx/issues/33373 Use approach suggested in dotnet/corefx#33476 * Skip tests for IPAddress.Address setter throwing on .NET Framework Commit migrated from dotnet/corefx@10dc9a2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://github.com/dotnet/corefx/issues/33373 using the approach suggested in PR #33476
/cc @alfredmyers @stephentoub