Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview-27204-02, preview.18604.2, preview-27204-02, beta-27204-00, beta-27203-01, respectively (master) #33783
Conversation
|
Discarded CI Status: 1:x: 5:hourglass: 7:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
38982b8 to
5a8f10f
Compare
|
Discarded CI Status: 2:x: 3:hourglass: 8:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
5a8f10f to
1c0f8e5
Compare
|
Discarded CI Status: 5:hourglass: 8:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
1c0f8e5 to
c9fdfba
Compare
|
Discarded CI Status: 5:hourglass: 8:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
c9fdfba to
eff0cee
Compare
|
Discarded CI Status: 8:hourglass: 5:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
eff0cee to
3c11c04
Compare
|
Discarded CI Status: 5:hourglass: 8:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
3c11c04 to
a5643e2
Compare
|
Discarded CI Status: 8:hourglass: 5:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
a5643e2 to
d852860
Compare
|
Discarded CI Status: 5:hourglass: 8:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
d852860 to
5f1dcd8
Compare
|
Looks like there are a few COM Interop test failures, such as:
|
|
Looking at the failures and recent PRs in CoreCLR, this might be related to dotnet/coreclr#20919. CC. @janvorli and @jkotas |
|
Discarded CI Status: 3:x: 10:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
5f1dcd8 to
af2e6fa
Compare
|
Agreed. To be safe, you could change the TFS auto-publish def to point to a different build-info location so you can try out more potential fixes without making changes to auto-update PRs. (I forget if you'd also need to seed/initially create the new build-info files on dotnet/versions for this particular def, sorry.) |
|
@zamont I would expect it to update again in the next few hours, as it has been doing periodically above. It keeps doing that until someone merges. |
|
@zamont The maestro trigger is on The typical way to manually trigger Maestro is to change the You could edit some other file that triggers the auto-update def, if one of those is safe: https://github.com/dotnet/versions/blob/da5f1cb4e282940acc092335083b062a777dccf3/Maestro/subscriptions.json#L424-L431. Otherwise, once one of those gets an normal update (like a CoreCLR build completing) then this PR will update normally and update the You could also run the |
|
Writing that out, I realized it might be worth it to add a trigger for each commonly used auto-update subscription that points to a file like |
|
Can't see the test failures anymore but #33824 may fix them |
|
I just updated this branch after running UpdateToRemoteDependencies locally. We should see the COM unsupported tests fail again, and then once the #33824 is merged we'll hopefully see all green. |
|
Couldn't update this pull request: Head commit author 'Zach Montoya' is not 'dotnet-maestro-bot' |
|
test Tizen armel Debug Build |
|
Couldn't update this pull request: Head commit author 'Zach Montoya' is not 'dotnet-maestro-bot' |
|
Couldn't update this pull request: Head commit author 'Zach Montoya' is not 'dotnet-maestro-bot' |
|
Couldn't update this pull request: Head commit author 'Zach Montoya' is not 'dotnet-maestro-bot' |
|
CC. @janvorli, looks like there are still some failures related to collectible COM classes:
|
|
@tannergooding it looked like @janvorli's changes went in but maestro-bot failed to update because I manually pushed to the branch. To move forward I pushed the dependency update manually again so we'll see if there are any remaining failures on this CI run. |
|
I'm not so sure. Several of the tests did pass (as compared to the original failures) after Jan's initial fix and the previous jobs looked to have updated to include the those changes
|
|
I did not know we had these old collectible tests. I'll send out a PR that removes these tests in a minute. |
|
Couldn't update this pull request: Head commit author 'Zach Montoya' is not 'dotnet-maestro-bot' |
… preview-27204-02, preview.18604.2, preview-27204-02, beta-27204-00, beta-27203-01, respectively
…ered to trigger on updates to ProjectNTfsTestILC
…ctNTfsTestILC to preview-27205-02, preview.18605.2, preview-27205-01, beta-27205-00, beta-27205-00, respectively'
tannergooding
force-pushed
the
master-UpdateDependencies
branch
from
ee11d3f to
6beb234
Compare
|
Rebased the changes onto the HEAD of master in order to resolve the merge conflicts. |
|
Looks like there is still a failure in:
It would likely be useful to disable or delete any additional tests as part of this PR to ensure that we get them all. |
|
Couldn't update this pull request: Head commit author 'Tanner Gooding' is not 'dotnet-maestro-bot' |
… preview-27204-02, preview.18604.2, preview-27204-02, beta-27204-00, beta-27203-01, respectively (master) (dotnet#33783) * Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview-27204-02, preview.18604.2, preview-27204-02, beta-27204-00, beta-27203-01, respectively * Manually run UpdateToRemoteDependencies because master was not registered to trigger on updates to ProjectNTfsTestILC * Manually apply 'Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview-27205-02, preview.18605.2, preview-27205-01, beta-27205-00, beta-27205-00, respectively' * Remove test for disabled collectible COM interop
… preview-27204-02, preview.18604.2, preview-27204-02, beta-27204-00, beta-27203-01, respectively (master) (dotnet/corefx#33783) * Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview-27204-02, preview.18604.2, preview-27204-02, beta-27204-00, beta-27203-01, respectively * Manually run UpdateToRemoteDependencies because master was not registered to trigger on updates to ProjectNTfsTestILC * Manually apply 'Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview-27205-02, preview.18605.2, preview-27205-01, beta-27205-00, beta-27205-00, respectively' * Remove test for disabled collectible COM interop Commit migrated from dotnet/corefx@758145a
/cc @dotnet/maestro-reviewers-core