This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Allow JsonConverterAttribute to be applied to an Enum #39790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyKuhne
approved these changes
Jul 26, 2019
|
Test failures for (musl_x64_Debug, MacOS x64_Debug and Windows x86_Release) not related: Infrastructure Execution Logs on: |
steveharter
added a commit
to steveharter/dotnet_corefx
that referenced
this pull request
Jul 26, 2019
steveharter
added a commit
that referenced
this pull request
Jul 26, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/corefx/issues/39741
Add capability to specify custom converter for an Enum by using [JsonConverter] just like we support for properties, etc.
This does affect the ref/System.Text.Json.cs but only to change the attribute targets (not really an API change).
@ericstj assuming approved for master, requesting approval for release/3.0.