Skip to content

Clarify that optional/required isn't relevant in ctor or indexer signatures #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

jskeet
Copy link
Contributor

@jskeet jskeet commented Nov 23, 2023

Fixes #782.

(I hadn't noticed that the same thing is relevant for indexers.)

…atures

Fixes dotnet#782.

(I hadn't noticed that the same thing is relevant for indexers.)
@jskeet jskeet added the meeting: discuss This issue should be discussed at the next TC49-TG2 meeting label Nov 23, 2023
@jskeet jskeet requested a review from BillWagner November 23, 2023 10:45
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @jskeet

Let's :shipit:

@jskeet jskeet merged commit dc288d9 into dotnet:draft-v8 Nov 29, 2023
@jskeet jskeet deleted the constructor-signatures branch November 29, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meeting: discuss This issue should be discussed at the next TC49-TG2 meeting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible issue with constructor parameters
4 participants