Skip to content

Add notnull example #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 16, 2025
Merged

Add notnull example #1309

merged 3 commits into from
Apr 16, 2025

Conversation

jskeet
Copy link
Contributor

@jskeet jskeet commented Apr 15, 2025

Fixes #1256

@jskeet jskeet added the meeting: discuss This issue should be discussed at the next TC49-TG2 meeting label Apr 15, 2025
@jskeet jskeet requested a review from a team April 15, 2025 15:29
Nigel-Ecma
Nigel-Ecma approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@Nigel-Ecma Nigel-Ecma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Only suggestion would be to extend the scope of the PR to the previous line (490) where the tense is wrong – it has “it is treated” where it should be some form of shall (as this is a spec not a description of compiler behaviour).

jnm2
jnm2 reviewed Apr 16, 2025
View reviewed changes
@jskeet
Copy link
Contributor Author

jskeet commented Apr 16, 2025

This is a good start, but we should also add examples for class? and interaction with type arguments which are themselves type parameters. Will leave #1256 open for that purpose.

@jskeet jskeet merged commit 6389cd0 into dotnet:draft-v8 Apr 16, 2025
6 checks passed
@Nigel-Ecma Nigel-Ecma mentioned this pull request Apr 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nigel-Ecma Nigel-Ecma Nigel-Ecma approved these changes

@jnm2 jnm2 jnm2 approved these changes

Assignees
No one assigned
Labels
meeting: discuss This issue should be discussed at the next TC49-TG2 meeting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Come up with an example-only version of #830
3 participants
@jskeet @Nigel-Ecma @jnm2