Grammar – Consistency & Cleanup 3 #1318
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Continues on from #1291 Grammar – Consistency & Cleanup 2]
This PR makes to small minor changes to the grammar, first it removes the unnecessary type_arguments, changing:
to the more direct:
Second it moves the optional trailing comma on attribute into the list, changing:
to the simpler:
This has the advantage that the trailing comma is now part of the list and not a level
above, and simplifies the first two by removing the overlapping alternatives.
No text changes are required to support these grammar improvements.
This PR also updates the grammar checker framework to v2.3.2, which includes an improved
implementation of C#’s semantic rules for declaration_expression. For the details see its repo.
Review Notes:
You only need to consider the changes to the
*.md
files instandard
; the other files are machine-generated updates to parsing test samples describing the new expected parse for some samples. If you wish to see visualisations of the changes you may download the changed*.svg
files in the PR and the current versions of them indraft-v8
and view them side-by-side (multiple monitors helps!)