C# 7.x: enhanced generic constraints #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
converting to draft: C# 7 feature |
BillWagner
force-pushed
the
Rex-v7-enhanced-generic-constraints
branch
from
35805a1 to
a388043
Compare
BillWagner
reviewed
Jun 8, 2022
BillWagner
reviewed
Jun 8, 2022
Nigel-Ecma
requested changes
Sep 5, 2022
Describe what happens when a type called `unmanaged` exists in the scope of an unmanaged constraint.
BillWagner
force-pushed
the
Rex-v7-enhanced-generic-constraints
branch
from
7e5894b to
c010892
Compare
jskeet
reviewed
Jan 31, 2023
Nigel-Ecma
requested changes
Jan 31, 2023
There was a problem hiding this comment.
I've thumbed up Jon's suggestions, made my previous suggestion into a formal one (which took me 4 suggestions, couldn't figure out how to do a single multiline one), and added a new one to avoid repetition.
If the re-wording suggestion is adopted then unamanaged needs to be added to contextual_keyword in §6.4.4 Keywords
BillWagner
approved these changes
Feb 1, 2023
Co-authored-by: Nigel-Ecma <[email protected]> Co-authored-by: Jon Skeet <[email protected]>
BillWagner
reviewed
Feb 1, 2023
|
@Nigel-Ecma Can you approve the changes on this PR? I think Rex and I have addressed all your comments, or accepted your suggesitons. |
Remove V6-specific entries, and add first new V7 items.
|
Per Nigel's request, add |
BillWagner
added a commit
to BillWagner/docs
that referenced
this pull request
Feb 5, 2023
see dotnet/csharpstandard#244 The standard draft language has been updated to add the `unmanaged` generic constraint. Remove the feature speclet from the docs site.
IEvangelist
pushed a commit
to dotnet/docs
that referenced
this pull request
Feb 6, 2023
see dotnet/csharpstandard#244 The standard draft language has been updated to add the `unmanaged` generic constraint. Remove the feature speclet from the docs site.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the following kinds of primary constraints:
unmanaged,System.Enum, andSystem.Delegate.