Parse (and format) ANTLR fragment productions in the Word converter #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should enable dotnet#339 and dotnet#342 in terms of Word conversion.
BillWagner
approved these changes
Jun 28, 2021
| /// <summary> | ||
| /// Whether or not this production is a fragment | ||
| /// </summary> | ||
| public bool Fragment { get; set; } |
There was a problem hiding this comment.
Not necessary, but it looks like this could be an init only property once we move to C# 9. I only see it set in the property initializer.
Suggested change
| public bool Fragment { get; set; } | |
| public bool Fragment { get; init; } |
There was a problem hiding this comment.
Yes, I suspect that may well be fine. I was mostly following the rest of the properties. I'd prefer to leave it as it is for now, and then revisit holistically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should enable #339 and #342 in terms of Word conversion.