-
Notifications
You must be signed in to change notification settings - Fork 90
First pass at tooling to allow examples to be tested #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Very rough and ready, and will need to be expanded (e.g. for expected exceptions) but it's enough to at least start a discussion. Not yet tested on non-Windows platforms.
Note that I've deliberately chosen Json.NET as it's pleasantly (in this case) lax about JSON - so we don't need to add quotes around the property keys, for example. Nothing is set in stone though. Sample output:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start @jskeet
Let's
Just before we merge, could you double check (maybe perhaps with @RexJaeschke or @Nigel-Ecma as well) that the few changes I've made inside the examples are okay? I think just around line 224 in classes.md would be the bit to check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any issue with the renaming in the code ~224 in classes.md
As to the rest I've more questions than answers at present. I haven't looked at the tool's code. However I noted in emails that this hasn't been tested cross-platform yet – is that important for this? As Microsoft error codes are embedded in the MD this isn't going to be cross-compiler, but I'd say that's fine for a tool we're running internally. I do wonder though whether we should be embedding Microsoft specific error codes in the Standard's MD source, or at least documenting that these are not part of the Standard per se but just there for TG2 internal tooling?
It will be, yes - because we'll want to run it as a GitHub action. I don't anticipate it being a problem, but we'll want to test it.
I suggest we document in a README either in the top level or under |
Very rough and ready, and will need to be expanded (e.g. for expected exceptions) but it's enough to at least start a discussion.
Not yet tested on non-Windows platforms.
Towards #614.