-
Notifications
You must be signed in to change notification settings - Fork 90
C# v7.x: Throw Expressions #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
314ad37
to
f65e854
Compare
This PR adds the new section, "§throw-expression-operator-new-clause The throw expression operator", which defines the grammar rule throw_expression. However, that rule is not currently reachable, so we need to figure out where to insert it in the expressions rule hierarchy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making progress!
Opening up for broader review - it looks like this still has quite a bit that needs doing though. |
I gave it a thorough read. I don't have any additional comments beyond what Neal and Nigel have already noted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If both Nigel and Neal are present in today's meeting, let's talk about the grammar aspect then.
Action: @gafter to apply his own suggestions. We have persuaded @Nigel-Ecma that leaving the prohibition of |
I think I've made all the changed that we have discussed. This is ready for further review. |
I don't know how to fix the section numbering issues. |
dc16438
to
63133d5
Compare
it appears that once any vertical bar is escaped in a table, they all must be.
I took another look at this while I was rebasing the V7 PRs. I think this is very close. The remaining concern is related to modifying the grammar or allowing the syntactic ambiguity and relying on the prose to disallow The next meeting where both @Nigel-Ecma and @gafter are present, we can resolve this and accept it with necessary recomendations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, my "comment" became a "review", must have hit the wrong button, nothing to add here to the comment!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor fix and this is approved. I've recommended leaving the grammar as is in the debate over style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Bill Wagner <[email protected]>
This requires a bit more work.