Skip to content

C# v7.x: Throw Expressions #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Oct 12, 2022
Merged

C# v7.x: Throw Expressions #65

merged 16 commits into from
Oct 12, 2022

Conversation

RexJaeschke
Copy link
Contributor

This requires a bit more work.

@RexJaeschke RexJaeschke added this to the C# 7.x milestone Dec 10, 2020
@BillWagner BillWagner force-pushed the Rex-throw-expression branch 3 times, most recently from 314ad37 to f65e854 Compare April 2, 2022 20:07
@gafter gafter self-assigned this Apr 13, 2022
@RexJaeschke
Copy link
Contributor Author

This PR adds the new section, "§throw-expression-operator-new-clause The throw expression operator", which defines the grammar rule throw_expression. However, that rule is not currently reachable, so we need to figure out where to insert it in the expressions rule hierarchy.

Copy link
Member

@gafter gafter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making progress!

@gafter gafter added the Review: complete at least one person has reviewed this label May 11, 2022
@gafter gafter assigned gafter and unassigned gafter May 11, 2022
@jskeet jskeet marked this pull request as ready for review June 15, 2022 12:42
@jskeet
Copy link
Contributor

jskeet commented Jun 15, 2022

Opening up for broader review - it looks like this still has quite a bit that needs doing though.

@BillWagner
Copy link
Member

Opening up for broader review - it looks like this still has quite a bit that needs doing though.

I gave it a thorough read. I don't have any additional comments beyond what Neal and Nigel have already noted.

Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If both Nigel and Neal are present in today's meeting, let's talk about the grammar aspect then.

@jskeet jskeet removed the Review: complete at least one person has reviewed this label Jul 13, 2022
@jskeet
Copy link
Contributor

jskeet commented Jul 13, 2022

Action: @gafter to apply his own suggestions. We have persuaded @Nigel-Ecma that leaving the prohibition of throw throw throw can be semantic.

@gafter gafter added meeting: discuss This issue should be discussed at the next TC49-TG2 meeting Review: complete at least one person has reviewed this and removed Review: work pending labels Jul 14, 2022
@gafter
Copy link
Member

gafter commented Jul 14, 2022

I think I've made all the changed that we have discussed. This is ready for further review.

@gafter
Copy link
Member

gafter commented Jul 14, 2022

I don't know how to fix the section numbering issues.

@BillWagner BillWagner force-pushed the Rex-throw-expression branch from dc16438 to 63133d5 Compare October 2, 2022 20:41
it appears that once any vertical bar is escaped in a table, they all must be.
@BillWagner
Copy link
Member

@jskeet

I took another look at this while I was rebasing the V7 PRs. I think this is very close. The remaining concern is related to modifying the grammar or allowing the syntactic ambiguity and relying on the prose to disallow throw throw throw.

The next meeting where both @Nigel-Ecma and @gafter are present, we can resolve this and accept it with necessary recomendations.

Copy link
Contributor

@Nigel-Ecma Nigel-Ecma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, my "comment" became a "review", must have hit the wrong button, nothing to add here to the comment!

Copy link
Contributor

@Nigel-Ecma Nigel-Ecma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor fix and this is approved. I've recommended leaving the grammar as is in the debate over style.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @jskeet

Let's merge #628, then manage the conflicts here, and merge this.

@BillWagner BillWagner merged commit 881c043 into draft-v7 Oct 12, 2022
@BillWagner BillWagner deleted the Rex-throw-expression branch October 12, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meeting: discuss This issue should be discussed at the next TC49-TG2 meeting Review: complete at least one person has reviewed this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants