Skip to content

Allow unsafe code in examples #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2022
Merged

Allow unsafe code in examples #650

merged 1 commit into from
Oct 27, 2022

Conversation

jskeet
Copy link
Contributor

@jskeet jskeet commented Oct 26, 2022

Towards #646.

@jskeet jskeet requested a review from RexJaeschke October 26, 2022 14:11
RexJaeschke
RexJaeschke requested changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@RexJaeschke RexJaeschke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice, simple solution, Jon! However, now that we have template "code-in-main", we should enable unsafe mode there as well, no? I'm not sure we have any unsafe top-level examples, but I see no reason to preclude them.

@RexJaeschke RexJaeschke mentioned this pull request Oct 26, 2022
Closed
20 tasks
@jskeet
Copy link
Contributor Author

jskeet commented Oct 27, 2022

Yes - didn't do it before as they were independent PRs, but I'll do it today.

@jskeet
Copy link
Contributor Author

jskeet commented Oct 27, 2022

Added now - PTAL and merge if you're happy.

@RexJaeschke RexJaeschke merged commit e3cab89 into dotnet:draft-v7 Oct 27, 2022
@jskeet jskeet deleted the allow-unsafe branch October 27, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RexJaeschke RexJaeschke RexJaeschke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jskeet @RexJaeschke