Skip to content

Remove references to pointers within the standard where appropriate. #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2023
Merged

Remove references to pointers within the standard where appropriate. #678

merged 1 commit into from
Feb 1, 2023

Conversation

jskeet
Copy link
Contributor

@jskeet jskeet commented Dec 1, 2022 •
edited
Loading

  • They're still present in the grammar, and in explanatory paragraphs after relevant grammar sections.
  • There are references in Annexes B and D, but that feels reasonable.

Fixes #676

@jskeet jskeet requested review from BillWagner and gafter December 1, 2022 09:29
jskeet
jskeet commented Dec 1, 2022
View reviewed changes
Copy link
Contributor Author

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This "review" is intended to provide justification for each removal, ensuring that we're not losing information.

@jskeet
Remove references to pointers within the standard where appropriate.
d6e349b 
- They're still present in the grammar, and in explanatory
  paragraphs after relevant grammar sections.
- There are references in Annexes B and D, but that feels reasonable.

Fixes dotnet#676.
BillWagner
BillWagner approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jskeet

This LGTM.

@jskeet jskeet added the meeting: discuss This issue should be discussed at the next TC49-TG2 meeting label Jan 23, 2023
Nigel-Ecma
Nigel-Ecma reviewed Feb 1, 2023
View reviewed changes
Copy link
Contributor

@Nigel-Ecma Nigel-Ecma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes all look OK to me.

While I can see the value in adding the information to the Unsafe Code clause, I don't see the value of removing it from where it is now.

If this is the direction we wish to go the PR can be approved.

@BillWagner BillWagner merged commit 02d7b26 into dotnet:draft-v7 Feb 1, 2023
@RexJaeschke
Copy link
Contributor

TG2 call of 2023-02-01: Approved with change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nigel-Ecma Nigel-Ecma Nigel-Ecma left review comments

@BillWagner BillWagner BillWagner approved these changes

@gafter gafter Awaiting requested review from gafter

Assignees
No one assigned
Labels
meeting: discuss This issue should be discussed at the next TC49-TG2 meeting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate out unsafe content into the unsafe chapter
4 participants
@jskeet @RexJaeschke @BillWagner @Nigel-Ecma