Skip to content

Add multi-file functionality (for a single project) #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

jskeet
Copy link
Contributor

@jskeet jskeet commented Feb 7, 2023

This fixes almost all examples where multiple files are required, example for VersioningOfConstantsAndStaticReadonlyFields1/2, which actually require multiple projects.

A few examples marked as requiring multiple files actually only needed additional files. It would be nice to be able to grab code from other examples to avoid maintenance notes, but that can be done later.

Note that the additional files generated have no template, and therefore no implicit using directives - hence the addition of "using System.Diagnostics;" in a couple of examples. This is slightly unfortunate, but not a significant issue - and the alternative of specifying template files would be much more work.

With this change in place, we will have 470 tested examples.

This fixes almost all examples where multiple files are required, example for VersioningOfConstantsAndStaticReadonlyFields1/2, which actually require multiple *projects*.

A few examples marked as requiring multiple files actually only needed additional files. It would be nice to be able to grab code from other examples to avoid maintenance notes, but that can be done later.

Note that the additional files generated have no template, and therefore no implicit using directives - hence the addition of "using System.Diagnostics;" in a couple of examples. This is *slightly* unfortunate, but not a significant issue - and the alternative of specifying template files would be much more work.

With this change in place, we will have 470 tested examples.
@RexJaeschke RexJaeschke merged commit 0767268 into dotnet:draft-v7 Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants