Skip to content

Address issue #839 #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2023
Merged

Address issue #839 #917

merged 1 commit into from
Sep 4, 2023

Conversation

Nigel-Ecma
Copy link
Contributor

The original text appeared to restrict the left operand to variables declared ref or ref readonly when a writeable or read-only ref is allowed.

@Nigel-Ecma
Address issue #839
f732ff3 
The original text appeared to restrict the left operand to variables declared `ref` or `ref readonly` when a writeable or read-only ref is allowed.
@Nigel-Ecma Nigel-Ecma added this to the C# 7.x milestone Sep 2, 2023
@Nigel-Ecma Nigel-Ecma mentioned this pull request Sep 2, 2023
Closed
jskeet
jskeet approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this looks okay to me. Admittedly it feels a little odd to have the two "If this then that" approaching things from opposite sides - but it's possibly the simplest way of expressing it.

@jskeet jskeet merged commit 25f2f84 into dotnet:draft-v7 Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jskeet jskeet jskeet approved these changes

@BillWagner BillWagner Awaiting requested review from BillWagner

@gafter gafter Awaiting requested review from gafter

@MadsTorgersen MadsTorgersen Awaiting requested review from MadsTorgersen

@RexJaeschke RexJaeschke Awaiting requested review from RexJaeschke

@ericlippert ericlippert Awaiting requested review from ericlippert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
C# 7.x
Development

Successfully merging this pull request may close these issues.
2 participants
@Nigel-Ecma @jskeet