Skip to content

Fix editorial nits #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 1, 2023
Merged

Fix editorial nits #964

merged 14 commits into from
Nov 1, 2023

Conversation

RexJaeschke
Copy link
Contributor

Bill, these are editorial fixes I noticed when reviewing the Word version of V7:

  • Change all "must" in normative text to "shall," or rewrite, as needed.
  • Change "Standard" to "specification."
  • Plus a few minor nits.

@RexJaeschke RexJaeschke requested a review from BillWagner October 7, 2023 16:44
jskeet
jskeet reviewed Oct 9, 2023
View reviewed changes
Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly fine, just a couple of points to consider.

BillWagner
BillWagner requested changes Oct 10, 2023
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RexJaeschke

I agree with Jon's and Nigel's comments, and offered suggestions.

One we resolve those, this is ready.

@Nigel-Ecma Nigel-Ecma mentioned this pull request Oct 10, 2023
Open
Nigel-Ecma
Nigel-Ecma requested changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@Nigel-Ecma Nigel-Ecma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added comments as responses in conversations. Some fixup required in issues this PR brought to light. (Note: I've only reviewed the conversations.)

@RexJaeschke RexJaeschke added the meeting: discuss This issue should be discussed at the next TC49-TG2 meeting label Oct 23, 2023
@RexJaeschke RexJaeschke merged commit 9965cce into dotnet:draft-v8 Nov 1, 2023
@RexJaeschke RexJaeschke deleted the Rex-fix-editorial-nits branch November 1, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@jskeet jskeet jskeet approved these changes

@Nigel-Ecma Nigel-Ecma Nigel-Ecma approved these changes

Assignees
No one assigned
Labels
meeting: discuss This issue should be discussed at the next TC49-TG2 meeting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RexJaeschke @jskeet @BillWagner @Nigel-Ecma