Add additional example annotation support files #969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillWagner
approved these changes
Oct 25, 2023
now.
RexJaeschke
pushed a commit
to RexJaeschke/csharpstandard
that referenced
this pull request
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bill, when looking at example testing failures on the V8 Draft PRs, I discovered that a number of tests failed because supporting files had not been uploaded. This PR adds all such supporting files. Once you have merged this, I'll resume looking for any other testing failures on those Draft PRs.
Looking at the diffs below, it seems that 2 of the 10 files already exist. But as their proposed replacements appear to be identical, I presume that leaving them in this batch is OK.