-
Notifications
You must be signed in to change notification settings - Fork 89
Reverse some V7 edits w.r.t Indexers #970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverse some V7 edits w.r.t Indexers #970
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM @RexJaeschke
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've suggested the undoing of the first change and the possible adding of text to §15.6.1. This avoids duplication of the material, as already occurs for properties.
If the duplication is felt warranted then it should also occur in properties and if the abstract virtual remark is kept it should be added to §15.6.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have agreed to remove the paragraph at 4191 in classes.md; after that, Rex can merge.
During the final integration of the ref-related feature text into draft-v7, 15.9, "Indexers" was broken into 15.9.1, "General" and 15.9.2 "Indexer and Property Differences," and some of the previous content was moved around, deleted, and/or edited.
A. The following para was deleted from 15.9.1:
When I discussed this privately with Bill, he thought this might be true for all member functions, not just indexers. However, I couldn't find any such text under Methods. (And we don't have a general "member-function" section to state such things anyway.) So, I restored this para.
B. The following para was duplicated, and I removed the first occurrence:
C. V6 contained the following:
This was removed and summarized in a Note in the (new) 15.9.1, as follows:
This introduced several problems: It made this informative, and it removed three term definitions (which we use throughout), while suggesting that a series of new-parallel terms existed, without normatively enumerating them.
After discussing this with Bill, I propose replacing that Note with the following normative text:
FYI, the reason I stumbled on this was while writing the spec for init accessors in V9. This requires the addition of a 3rd flavor of terms: read-init property/indexer and init-only property/indexer.