-
Notifications
You must be signed in to change notification settings - Fork 89
Update our tools to run on >NET 8 #996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There were some breaking changes in the Word Converter packages. The only source code changes were to address the Word converter source breaks.
Review this diff by hiding whitespace. First, remove all unnecessary usings. Second, convert all namespace declarations to file scoped namespaces.
This one is consistent with the version on dotnet/docs. We can season to taste as we're ready.
I've got a PR in that repo to update it. Once approved, I'll install the NuGet package here, and update that YML file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits. Yes, we'll need to work out what to do about the F# Markdown package.
- Update Roslyn packages to 4.8 - Remove coverlet - Formatting in csproj.
I'm still getting warnings:
The commit for the update to Formatting v17 includes "Now, the warning on dependencies has gone away. (The F# formatter approves of the new F# compiler)" - have the warnings still gone away for you, even with 19.1.1? |
I am still getting it on the build, but not in the NuGet CLI. Interesting. |
Changes in order of commits:
Note on NuGet packages:
I tried updating the FSharp.Formatting package. The Markdown converter is using version 4.0.1, and the latest is on version 19. Version 20 is in alpha. There are a small number of source breaking changes in APIs. Those were straightforward. You can see them reverted in the 2nd commit. The reason I reverted them is that the behavior is different, and I couldn't get everything working in a reasonable amount of time. There's two behavior issues stopping the update:
**
in the word doc.I'll make an issue for these so we can work on that when either Jon or I have time.