-
Notifications
You must be signed in to change notification settings - Fork 75
Update Linux setup scripts to allow Enter key as default confirmation (Y) #1294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… (Y) Co-authored-by: waldekmastykarz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the logic so that the script continues only on y
, Y
or Enter but not on anything else.
…r input Co-authored-by: waldekmastykarz <[email protected]>
Updated the logic to only continue on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect. Now also update the PowerShell version of the Linux setup script in setup.ps1 and setup-beta.ps1
…ation (Y) Co-authored-by: waldekmastykarz <[email protected]>
Updated the PowerShell setup scripts ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update all scripts so that:
- pressing
Y
,y
or Enter continues installation - pressing anything else cancels it
- there's no need to confirm the key with an enter (eg.
Y
+ Enter), just press one key
…Y/y/Enter Co-authored-by: waldekmastykarz <[email protected]>
Updated all setup scripts to require single key press only:
Fixed in commit 4842174. |
The Linux setup scripts (
setup.sh
andsetup-beta.sh
) previously required users to explicitly typey
to confirm installation steps. This PR updates both scripts to useY
as the default value, allowing users to simply press Enter to confirm, which improves usability and aligns with common CLI conventions.Changes Made
Before:
After:
Key Improvements:
(y/n)?
to(Y/n)?
to clearly indicate Y is the default-n1
flag to allow Enter key input (reads full line instead of single character)Behavior:
This change makes the setup process more user-friendly while maintaining backward compatibility and follows the same pattern used in other scripts like
trust-cert.sh
.Fixes #1288.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
https://github.com/api/repos/dotnet/dev-proxy/releases/latest
curl -s REDACTED
(http block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.