Skip to content

Makes OIDC metadata URL configurable. Closes #1328 #1329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025

Conversation

waldekmastykarz
Copy link
Collaborator

Makes OIDC metadata URL configurable. Closes #1328

@Copilot Copilot AI review requested due to automatic review settings July 16, 2025 09:24
@waldekmastykarz waldekmastykarz added the pr-bugfix Fixes a bug label Jul 16, 2025
@waldekmastykarz waldekmastykarz requested a review from a team as a code owner July 16, 2025 09:24
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes the OIDC (OpenID Connect) metadata URL configurable in the AuthPlugin, replacing the previously hardcoded Microsoft Azure AD endpoint. This change allows users to configure Dev Proxy to work with different identity providers beyond just Microsoft's Azure AD.

Key Changes

  • Modified the SetupOpenIdConnectConfigurationAsync method to accept a configurable metadata URL parameter
  • Updated the method call to pass the metadata URL from the plugin configuration
  • Replaced hardcoded Microsoft-specific OIDC endpoint with a configurable value

@waldekmastykarz waldekmastykarz merged commit 427cdad into dotnet:main Jul 16, 2025
4 checks passed
@waldekmastykarz waldekmastykarz deleted the fix-auth-oid branch July 16, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Auth plugin not using metadataUrl parameter
2 participants