Refactors RequestLogs property to use ConcurrentBag for improved thread safety #1333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the RequestLogs property to use ConcurrentBag<T> instead of Collection<T> to improve thread safety in the proxy state management. This change addresses potential race conditions when multiple threads access the request logs simultaneously.
Key changes:
- Replaced
Collection<RequestLog>withConcurrentBag<RequestLog>for thread-safe operations - Updated corresponding using statements to reference
System.Collections.Concurrent
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| DevProxy/Proxy/ProxyState.cs | Updated RequestLogs property type and using statement |
| DevProxy/Proxy/IProxyState.cs | Updated interface definition to match new collection type |
waldekmastykarz
force-pushed
the
fix-requestlogs-racecondition
branch
from
9cfba7d to
bce3a67
Compare
garrytrinder
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.