Skip to content

Fixes Initializing AuthPlugin. Closes #1371 #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 26, 2025
Merged

Fixes Initializing AuthPlugin. Closes #1371 #1372

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ab161b
Fixes Initializing AuthPlugin. Closes #1371
waldekmastykarz Aug 26, 2025
864aed3
Merge branch 'main' into fix-auth-enabled
waldekmastykarz Aug 26, 2025
948a833
Update DevProxy.Plugins/Mocking/AuthPlugin.cs
waldekmastykarz Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion DevProxy.Plugins/Mocking/AuthPlugin.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,9 @@ public override async Task InitializeAsync(InitArgs e, CancellationToken cancell
{
await base.InitializeAsync(e, cancellationToken);

// Disable by default to support early exits on configuration errors
Enabled = false;

if (Configuration.Type == null)
{
Logger.LogError("Auth type is required");
Expand Down Expand Up @@ -153,7 +156,8 @@ public override async Task InitializeAsync(InitArgs e, CancellationToken cancell
await SetupOpenIdConnectConfigurationAsync(Configuration.OAuth2.MetadataUrl);
}

Enabled = false;
// Enable the plugin after successful initialization
Enabled = true;
}

public override Task BeforeRequestAsync(ProxyRequestArgs e, CancellationToken cancellationToken)
Expand Down