Updates logging from plugins. Closes #887 #890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrytrinder
previously approved these changes
Oct 1, 2024
waldekmastykarz
force-pushed
the
fix-logging
branch
from
7a14d89 to
4b36be3
Compare
waldekmastykarz
force-pushed
the
fix-logging
branch
from
4b36be3 to
ede6945
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates logging from plugins. Closes #887
Introduces new
skipmessages to help understand plugin execution. Skip messages are enabled by default and can be disabled using the newshowSkipMessagessetting in devproxyrc.json.This PR also introduces a breaking change, where we change the shape of a log message from
string[]tostring. This makes it easier to understand how plugins process a request, because each plugin logs a single message.