-
Notifications
You must be signed in to change notification settings - Fork 384
Closed
Labels
Priority:1Work that is critical for the release, but we could probably ship withoutWork that is critical for the release, but we could probably ship withoutsos
Milestone
Description
Looking through the code, I can see that DacpGcHeapDetails and GCHeapSnapShot have hardcoded generation limits. Now that the runtime has another heap these APIs will be incomplete.
The following SOS commands use DacpGcHeapDetails:
- !EEHeap
- !ListNearObj
- !GCWhere
- !GCHeapStat
- !FinalizeQueue
And these APIs use GCHeapSnapShot:
- !GCRoot
- !DumpStackObjects
- !DumpIL
- !TraverseHeap
- !DumpAsync
- !DumpHeap
- !VerifyHeap
- !VerifyObj
- !FindRoots
I haven't done any testing, but based on my reading of the code none of them should be broken, but they will not report objects out of the pinned object heap.
Metadata
Metadata
Assignees
Labels
Priority:1Work that is critical for the release, but we could probably ship withoutWork that is critical for the release, but we could probably ship withoutsos