fix: IOException is thrown when file access conflicts. #10786
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intended to fix #8654. (Related PR #10637 #10785)
What's changed in this PR
File.Create
tonew FileStream
withFileShare.ReadWrite
_noRandomFile
code.Background
There is a comment that
IOException
issue is occurred when build docs withdocfx serve
.It is possible for an IOException to be thrown when when the
docfx build
anddocfx serve
commands are executed in parallel.Because
File.Create
open file withFileShare.None
So it need to modify code to use
FileShare.ReadWrite
.If reported issue is not resolved by this changes.
It need to use retry logics that are proposed on other PRs