Implemented the simplest warnings as errors. #3230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lextm
requested review from
928PJY,
herohua,
live1206,
OsmondJiang,
superyyrrzz and
yufeih
as code owners
lextm
force-pushed
the
warnings-as-errors
branch
from
cf64ee2 to
9f79cc7
Compare
|
Thank you @lextm LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new option as documented in #3229.
By adding
--warningsAsErrors trueto the command line, any warning would trigger a return code of1which can be used to fail CI builds or any other scripts relying on the return code.