-
Notifications
You must be signed in to change notification settings - Fork 6k
Doc on Pipelines types #11347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc on Pipelines types #11347
Conversation
@Rick-Anderson can you help review this one? |
@mairaw I created dotnet/AspNetCore.Docs#11823 so the PU will review this on their next schedule hack-a-doc. |
Sounds good. I'll wait for their comments until I start reviewing these and applying some of our guidelines. For example, the right identifier for C# code is csharp, sample code should be hosted in https://github.com/dotnet/samples, etc. @KPixel one thing is that our TOC format changed from .md to yml so you now have some merge conflicts. |
@mairaw I will update the TOC when needed. Regarding moving sample codes to that separated repo, may I know what the rational is? It seems like a lot more work... (Edit: I understand for samples, but not for snippets) |
The goal is to have CI running on all samples in that repo so we know when code breaks when a new version is released, etc. We're not there yet. The checks done here are all just for content, not for code. |
That's fine for samples, but snippets are often written with assumptions (like no "using namespace") that make them impossible to compile... |
little snippets are fine to be inside the content |
Ok, I will wait for the reviews to work on all that. |
Hey @KPixel I'd like to take over this one. I started writing a detailed usage doc for pipelines that will supersede this one. Can we close this one for now. The plan I have is to:
|
Hi @davidfowl Glad to see that you are making progress here. If you are writing a new doc, can you take advantage of the illustration that I put together? |
@KPixel sure though that more fits the bedrock picture. Maybe we can do a modified version for IDuplexPipe as well? I plan to open a docs PR soon. I'm trying to get the content finished. |
Ok, feel free to let me know if I can do anything to help. |
Feel free to provide any initial feedback on https://github.com/davidfowl/DocsStaging |
I'll close this one then @KPixel. We surely appreciate you taking the time to get this started! |
Pipelines types
This is a new page on Pipelines.
Internal review URL Memory- and span-related types
Internal review URL Pipelines types
Fixes #7516
Notes