Improvements to definitions of metrics.md #12220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could still use an additional pass at some later point. Perhaps when we add in the missing definitions of ranking/clustering/etc metrics.
JRAlexander
reviewed
May 7, 2019
JRAlexander
reviewed
May 7, 2019
JRAlexander
suggested changes
May 7, 2019
Co-Authored-By: justinormont <[email protected]>
Co-Authored-By: justinormont <[email protected]>
JRAlexander
approved these changes
May 7, 2019
|
Nice work, @justinormont! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Few inaccuracies cleaned up, for instance NDCG is 0.00 to 1.00; was 0 to 100 previously and was changed in dotnet/machinelearning#2697 (and discussed in dotnet/machinelearning#2637). Expanded some guidelines, like when accuracy is non-useful.
Could still use an additional pass at some later point. Perhaps when we add in the missing definitions of ranking/clustering/etc metrics.
Also partially addresses: dotnet/machinelearning#3671