Skip to content

Create error page NETSDK1141 #23820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 3, 2021
Merged

Create error page NETSDK1141 #23820

merged 4 commits into from
May 3, 2021

Conversation

ghogen
Copy link
Contributor

@ghogen ghogen commented Apr 16, 2021

Summary

Add page for error message NETSDK1141 which deals with the SDK version in global.json.

Helps address issue #20656

This is a top F1 hit now that other NETSDK errors have been documented.

@ghogen ghogen marked this pull request as draft April 16, 2021 17:31
@ghogen
Copy link
Contributor Author

ghogen commented Apr 16, 2021

@tdykstra This is a draft now from Internet research, and needs validation and review from engineering.

@tdykstra
Copy link
Contributor

@tdykstra This is a draft now from Internet research, and needs validation and review from engineering.

@wli3 Who should review this PR?

@BillWagner BillWagner modified the milestones: April 2021, May 2021 May 3, 2021
@ghogen ghogen marked this pull request as ready for review May 3, 2021 20:28
@ghogen
Copy link
Contributor Author

ghogen commented May 3, 2021

@Youssef1313 @tdykstra Ready to merge?

Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done -- comprehensive, clear, and concise.

@tdykstra tdykstra merged commit cc2b798 into dotnet:main May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants