Fix note mistake: ObservableGauge can be substituted with ObservableCounter #29757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ounter With the previous wording it was weird: ObservableGauge can be substituted with ObservableGauge. If I am not mistaken `ObservableCounter` was meant there.
noahfalk
reviewed
Jun 9, 2022
noahfalk
reviewed
Jun 9, 2022
|
Thanks @voroninp! I agree that sentence is weird. I think the first mention of ObservableGauge was intended to be UpDownCounter. |
|
If you update your branch with the latest from upstream main, the build verifier error will go away. |
Co-authored-by: Noah Falk <[email protected]>
Co-authored-by: Noah Falk <[email protected]>
gewarren
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With the previous wording it was weird: ObservableGauge can be substituted with ObservableGauge. If I am not mistaken
ObservableCounterwas meant there.