docs: Improved dotnet github action #29769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@IEvangelist You're noted in the frontmatter as author, care to review? |
Youssef1313
reviewed
Jun 8, 2022
Youssef1313
reviewed
Jun 8, 2022
Youssef1313
reviewed
Jun 8, 2022
Co-authored-by: Youssef Victor <[email protected]>
IEvangelist
requested changes
Jun 8, 2022
There was a problem hiding this comment.
This looks great so far, thank you for the valuable contribution @svrooij. Could you please review the suggestions I've made and consider accepting them? Once you're done with that, I'll approve/merge this PR.
Co-authored-by: David Pine <[email protected]>
IEvangelist
approved these changes
Jun 8, 2022
|
@IEvangelist do you have any idea how long it usually takes for these new docs to appear on the docs page |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added performance improvements, mentioned already available environment variables and added a sample Github action build in .NET
Fixed #29701