Skip to content

New RateLimiter article showing a custom HTTP handler #31095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 15, 2022
Merged

New RateLimiter article showing a custom HTTP handler #31095

merged 13 commits into from
Sep 15, 2022

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Sep 9, 2022 •
edited
Loading

Summary

New RateLimiter article showing a custom HTTP handler

Fixes #30426

Preview

@dotnet-bot dotnet-bot added this to the September 2022 milestone Sep 9, 2022
@IEvangelist IEvangelist changed the title Draft and initial bits New RateLimiter article showing a custom HTTP handler Sep 14, 2022
@IEvangelist IEvangelist added the 🏁 Release: .NET 7 Work items for the .NET 7 release label Sep 14, 2022
@IEvangelist IEvangelist marked this pull request as ready for review September 14, 2022 18:41
@IEvangelist IEvangelist requested a review from a team as a code owner September 14, 2022 18:41
@IEvangelist
Copy link
Member Author

Hey @BillWagner, my only question for you on this is do we need to have something that calls attention to the fact that this is currently using the preview bits for .NET 7? Assuming yes, what is common for conceptual articles like this?

@tdykstra
Copy link
Contributor

do we need to have something that calls attention to the fact that this is currently using the preview bits for .NET 7?

Here's the include file I use at the top of System.CommandLine docs: https://github.com/dotnet/docs/blob/main/includes/scl-preview.md

BillWagner
BillWagner approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @IEvangelist

I found one typo, and had one suggestion to improve clarity. Then, once others are happy, :shipit:

@IEvangelist IEvangelist added okr-freshness OKR: Freshness of content okr-curation OKR: Curate content to remove outdated recommendations labels Sep 15, 2022
@IEvangelist IEvangelist merged commit 949a9cf into dotnet:main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy

Assignees
No one assigned
Labels
🏁 Release: .NET 7 Work items for the .NET 7 release dotnet-fundamentals/svc okr-curation OKR: Curate content to remove outdated recommendations okr-freshness OKR: Freshness of content
Projects
None yet
Milestone
September 2022
Development

Successfully merging this pull request may close these issues.

Rate Limiting for .NET
4 participants
@IEvangelist @tdykstra @BillWagner @dotnet-bot