Skip to content

StripSymbols default for PublishAOT #35229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 8, 2023
Merged

StripSymbols default for PublishAOT #35229

merged 8 commits into from
May 8, 2023

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented May 3, 2023 •
edited by github-actions bot
Loading

@dotnet-bot dotnet-bot added this to the May 2023 milestone May 3, 2023
@ghost ghost added the 🏁 Release: .NET 8 Work items for the .NET 8 release label May 3, 2023
@gewarren gewarren requested a review from MichalStrehovsky May 3, 2023 00:05
MichalStrehovsky
MichalStrehovsky approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

MichalStrehovsky
MichalStrehovsky approved these changes May 7, 2023
View reviewed changes
Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion - we're adding macOS support in .NET 8.

@gewarren gewarren enabled auto-merge (squash) May 8, 2023 15:40
@gewarren gewarren merged commit f1b66bb into dotnet:main May 8, 2023
@gewarren gewarren deleted the stripsymbols branch May 8, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichalStrehovsky MichalStrehovsky MichalStrehovsky approved these changes

@jkoritzinsky jkoritzinsky Awaiting requested review from jkoritzinsky jkoritzinsky is a code owner

@adegeo adegeo Awaiting requested review from adegeo adegeo is a code owner

Assignees
No one assigned
Labels
🏁 Release: .NET 8 Work items for the .NET 8 release dotnet-fundamentals/svc
Projects
No open projects
.NET 8.0 work items
Status: ✅ Done
Milestone
May 2023
Development

Successfully merging this pull request may close these issues.

[Breaking change]: StripSymbols=true is now the default option for PublishAot
3 participants
@gewarren @MichalStrehovsky @dotnet-bot