-
Notifications
You must be signed in to change notification settings - Fork 6k
Document NETSDK1195 #35655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document NETSDK1195 #35655
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good -- a couple of minor suggestions, and this article needs to be added to toc.yml
Co-authored-by: Tom Dykstra <[email protected]>
So there is no workaround for enabling the analyzers with netstandard libraries, right? |
There's no documented workaround, but it is possible to work around this by playing games with |
- Trimming (via `PublishTrimmed` or `PublishAot`) | ||
- Trim analysis (via `PublishTrimmed`, `PublishAot`, `IsTrimmable`, `IsAotCompatible`, or `EnableTrimAnalyzer`) | ||
- Single-file analysis (via `PublishSingleFile` or `EnableSingleFileAnalyzer`) | ||
- Ahead-of-time compilation analysis (via `PublishAot` or `EnableAotAnalyzer`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might give the false impression that AOT analysis will work on netcoreapp3.0
- maybe we should mention that this is only really supported on net7.0
and above.
Which leads me to another question: Maybe we should issue this warning when somebody targets net6.0
and sets PublishAot
for example. Or maybe we should have a similar warning for AOT. It's basically the same story as for trimming and netstandard2.0
. It won't do anything but it will provide false "hope" that the app doesn't have AOT incompatibilities.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a separate error about the ILCompiler pack - if you try PublishAot
on net6.0
it'll say:
error NETSDK1183: Ahead-of-time compilation is not supported for the target framework.
See dotnet/sdk#32943 which made this error more specific.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the AOT specific comment - which we should probably turn into a separate issue, this looks good.
Add detailed documentation on NETSDK1195, with actionable suggestions to resolve it.
Internal previews