add what's new in 7.2 #3672

BillWagner · 2017-11-14T01:57:17Z

Create the "What's new in C# 7.2 topic.

BillWagner · 2017-11-14T15:23:31Z

This is ready for review.

jcouv · 2017-11-14T18:07:38Z

docs/csharp/whats-new/csharp-7-2.md

+ - The `readonly struct` declaration indicates that a struct is immutable and should be passed as an `in` parameter to its members methods.
+ - The `ref struct` declaration indicates that a struct type accesses managed memory directly and must always be stack allocated.
+
+You can read more about all these changes in [Using value types with reference semantics](../ref-locals-and-returns.md).


This link is broken, or maybe not published yet. The URL worries me, as it seems to refer to the C# 7.0 feature ("ref locals and returns").

It's not published. It's in #3667

Good point on the link. I'll update it in the other PR once I have reviews on it.

jcouv · 2017-11-14T18:09:25Z

LGTM Thanks
Tagging @jaredpar @MadsTorgersen

rpetrusha

A number of comments and suggestions, @BillWagner.

rpetrusha · 2017-11-14T18:25:06Z

docs/csharp/whats-new/csharp-7-2.md

+One theme for this release is working more efficiently with value types by
+avoiding unnecessary copies or allocations. 
+
+The remaining features are small, nice to have features.


nit: nice to have --> nice-to-have

rpetrusha · 2017-11-14T18:27:14Z

docs/csharp/whats-new/csharp-7-2.md

+* [Non-trailing named arguments](#non-trailing-named-arguments)
+  - Named arguments can be followed by positional arguments.
+* [Leading underscores in numeric literals](#leading-underscores-in-numeric-literals)
+  - Number literals can now have leading underscores before any printed digits.


Number --> Numeric

rpetrusha · 2017-11-14T18:32:01Z

docs/csharp/whats-new/csharp-7-2.md

+## Reference semantics with value types
+
+Language features introduced in 7.2 enable scenarios
+for working with value types while using reference semantics. These features


This first sentence is difficult to parse. Perhaps:
enable scenarios for working with value types --> let you work with value types
These features --> They

rpetrusha · 2017-11-14T18:32:23Z

docs/csharp/whats-new/csharp-7-2.md

+
+Language features introduced in 7.2 enable scenarios
+for working with value types while using reference semantics. These features
+are designed to increase performance by minimize copying value types without


minimize --> minimizing

rpetrusha · 2017-11-14T18:35:13Z

docs/csharp/whats-new/csharp-7-2.md

+incurring the memory allocations associated with using reference types. The
+features include:
+
+ - The `in` modifier on parameters to specify that an argument is passed by reference, but not modified by the called method.


These four features should be parallel in structure. I personally like the format of the first one (, to , So my comments will assume all four will follow that format, but you could also make the in modifier conform to the other three.
comma after parameters, and no comma before but

rpetrusha · 2017-11-14T18:45:15Z

docs/csharp/whats-new/csharp-7-2.md

+
+## Leading underscores in numeric literals
+
+The first implementation of allowing `_` characters in numeric literals did not allow the


"of allowing _ characters in numeric literals" is not a good description. I'd change it to "The first implementation of support for digit separators in numeric literals...". Or mention 7.0 -- "The implementation of support for digit separators in C# 7.0 did not allow..."

rpetrusha · 2017-11-14T18:45:44Z

docs/csharp/whats-new/csharp-7-2.md

+## Leading underscores in numeric literals
+
+The first implementation of allowing `_` characters in numeric literals did not allow the
+`_` to be the first character of the literal value. Numeric


Not all numeric literals, but only binary and hex, no?

rpetrusha · 2017-11-14T18:47:02Z

docs/csharp/whats-new/csharp-7-2.md

+
+## `private protected`
+
+Finally, a new compound access modifier: `private protected`, indicates that a member may be


if you keep the colon, no comma after private protected. If you keep the comma after private protected, change the colon to a comma.

rpetrusha · 2017-11-14T18:47:44Z

docs/csharp/whats-new/csharp-7-2.md

+## `private protected`
+
+Finally, a new compound access modifier: `private protected`, indicates that a member may be
+accessed by derived classes that are declared in the same assembly. Where `protected internal`


Where --> While

rpetrusha · 2017-11-14T18:48:04Z

docs/csharp/whats-new/csharp-7-2.md

+
+Finally, a new compound access modifier: `private protected`, indicates that a member may be
+accessed by derived classes that are declared in the same assembly. Where `protected internal`
+access allows access by derived classes or classes that are in the same assembly, `private protected`


The first occurrence of "access" here can be deleted.

mairaw

LGTM. Some minor comments in addition to the ones already made by @rpetrusha

mairaw · 2017-11-14T19:00:41Z

docs/csharp/whats-new/csharp-7-2.md

+
+## Leading underscores in numeric literals
+
+The first implementation of allowing `_` characters in numeric literals did not allow the


I agree with @rpetrusha. Also use contractions: did not allow -> didn't allow

mairaw · 2017-11-14T19:03:25Z

docs/csharp/whats-new/csharp-7-2.md

+features include:
+
+ - The `in` modifier on parameters to specify that an argument is passed by reference, but not modified by the called method.
+ - The `ref readonly` modifier on method returns indicates that a method returns its value by reference but does not allow writes to that object.


nit: does not -> doesn't

mairaw · 2017-11-14T19:04:46Z

docs/csharp/whats-new/csharp-7-2.md

+## Non-trailing named arguments
+
+Method calls may now use named arguments that precede positional arguments when those
+named arguments are in the correct positions. Read more in the updated content for


I'd probably stick with the boilerplate sentence here. For more information, see ...

mairaw · 2017-11-14T19:06:34Z

docs/csharp/whats-new/csharp-7-2.md

+access allows access by derived classes or classes that are in the same assembly, `private protected`
+limits access to derived types declared in the same assembly.
+
+You can read more of the details in the language reference article on [access modifiers](../language-reference/keywords/access-modifiers.md).


again I'd probably stick with the boilerplate here.

BillWagner · 2017-11-14T21:35:29Z

Updated based on feedback. @mairaw @rpetrusha Can you take a look?

rpetrusha · 2017-11-14T21:48:58Z

LGTM, @BillWagner. The build is still in progress, but you can merge once the build finishes and it looks good.

BillWagner · 2017-11-15T01:30:30Z

Closing and reopening to force a build (to check a link)

* add what's new in 7.2 * prrofread and update * respond to feedback. * update referenced file name

BillWagner added 2 commits November 13, 2017 20:54

add what's new in 7.2

371ae2a

prrofread and update

c2b6087

BillWagner changed the title ~~[WIP] add what's new in 7.2~~ add what's new in 7.2 Nov 14, 2017

jcouv reviewed Nov 14, 2017

View reviewed changes

rpetrusha suggested changes Nov 14, 2017

View reviewed changes

mairaw reviewed Nov 14, 2017

View reviewed changes

BillWagner added 2 commits November 14, 2017 14:27

respond to feedback.

ac0cbaf

update referenced file name

b57c295

rpetrusha approved these changes Nov 14, 2017

View reviewed changes

BillWagner closed this Nov 15, 2017

BillWagner reopened this Nov 15, 2017

BillWagner merged commit 1278d21 into dotnet:master Nov 15, 2017

BillWagner deleted the whats-new-7-2 branch November 16, 2017 18:51

BillWagner mentioned this pull request Nov 16, 2017

Create "What's new in C# 7.2" topic #3243

Closed

JRAlexander pushed a commit to JRAlexander/docs that referenced this pull request Nov 20, 2017

add what's new in 7.2 (dotnet#3672)

d311434

* add what's new in 7.2 * prrofread and update * respond to feedback. * update referenced file name


		## Leading underscores in numeric literals

		The first implementation of allowing `_` characters in numeric literals did not allow the


		## `private protected`

		Finally, a new compound access modifier: `private protected`, indicates that a member may be

add what's new in 7.2 #3672

add what's new in 7.2 #3672

Uh oh!

Conversation

BillWagner commented Nov 14, 2017

Uh oh!

BillWagner commented Nov 14, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jcouv commented Nov 14, 2017

Uh oh!

rpetrusha left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mairaw left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BillWagner commented Nov 14, 2017

Uh oh!

rpetrusha commented Nov 14, 2017

Uh oh!

BillWagner commented Nov 15, 2017

Uh oh!

Uh oh!