Skip to content

String.Trim breaking change #43344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 6, 2024
Merged

String.Trim breaking change #43344

merged 5 commits into from
Nov 6, 2024

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Nov 5, 2024 •
edited by github-actions bot
Loading

@gewarren gewarren requested a review from a team as a code owner November 5, 2024 18:47
@dotnetrepoman dotnetrepoman bot added this to the November 2024 milestone Nov 5, 2024
BillWagner
BillWagner approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

I had one question, and then you can :shipit:

gewarren
gewarren commented Nov 6, 2024
View reviewed changes
@gewarren gewarren merged commit d0a5a09 into dotnet:main Nov 6, 2024
8 checks passed
@gewarren gewarren deleted the string-trim branch November 6, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adegeo adegeo adegeo left review comments

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
November 2024
Development

Successfully merging this pull request may close these issues.

[Breaking change]: string.Trim(params ReadOnlySpan<char>) has been removed from .NET 9
3 participants
@gewarren @BillWagner @adegeo