Skip to content

Conversation

@gewarren gewarren requested a review from a team as a code owner November 5, 2024 23:24
Copy link
Member

@liveans liveans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Query redaction LGTM, but I believe this also fixes #42792 not #42972
If @antonfirsov also can take a look on query redaction, that would be great.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Query redaction & server.port docs LGTM modulo a minor grammar issue.

@gewarren gewarren enabled auto-merge (squash) November 6, 2024 22:28
@gewarren gewarren merged commit 2ffa54a into dotnet:main Nov 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants