Update msdn links and simplify relative links #4895

mairaw · 2018-04-06T20:16:57Z

I've fixed all the http://msdn.microsoft.com links inside the interop folder (and if the same link was used elsewhere I've fixed that too)

Also related to #4504

rpetrusha

This looks good, @mairaw. There is still one broken link, one link with an incorrect URL, and two self-referencing links that should be removed. Once you fix those, this is ready to merge.

rpetrusha · 2018-04-07T16:31:15Z

docs/framework/interop/com-callable-wrapper.md

@@ -44,11 +39,11 @@ Accessing .NET objects through COM callable wrapper
 Unlike the .NET client it wraps, the CCW is reference-counted in traditional COM fashion. When the reference count on the CCW reaches zero, the wrapper releases its reference on the managed object. A managed object with no remaining references is collected during the next garbage-collection cycle.  

 ## Simulating COM interfaces  
- The [COM callable wrapper](../../../docs/framework/interop/com-callable-wrapper.md) (CCW) exposes all public, COM-visible interfaces, data types, and return values to COM clients in a manner that is consistent with COM's enforcement of interface-based interaction. For a COM client, invoking methods on a .NET Framework object is identical to invoking methods on a COM object.  
+ The [COM callable wrapper](com-callable-wrapper.md) (CCW) exposes all public, COM-visible interfaces, data types, and return values to COM clients in a manner that is consistent with COM's enforcement of interface-based interaction. For a COM client, invoking methods on a .NET Framework object is identical to invoking methods on a COM object.  


This is a self-referencing link and causes a page reload. It can be removed.

Good catch @rpetrusha! Also removed the acronym definition since we already exposed that earlier.

rpetrusha · 2018-04-07T16:40:39Z

docs/framework/interop/com-callable-wrapper.md

- [Simulating COM Interfaces](http://msdn.microsoft.com/library/ad2ab959-e2be-411b-aaff-275c3fba606c)  
- [Qualifying .NET Types for Interoperation](../../../docs/framework/interop/qualifying-net-types-for-interoperation.md)  
- [Runtime Callable Wrapper](../../../docs/framework/interop/runtime-callable-wrapper.md)
+ [COM Callable Wrapper](com-callable-wrapper.md)  


This is another self-referencing link.

rpetrusha · 2018-04-07T17:12:30Z

docs/framework/interop/default-marshaling-behavior.md

@@ -47,10 +42,10 @@ BSTR MethodOne (BSTR b) {

 However, if you define the method as a platform invoke prototype, replace each **BSTR** type with a <xref:System.String> type, and call `MethodOne`, the common language runtime attempts to free `b` twice. You can change the marshaling behavior by using <xref:System.IntPtr> types rather than **String** types.  

- The runtime always uses the **CoTaskMemFree** method to free memory. If the memory you are working with was not allocated with the **CoTaskMemAlloc** method, you must use an **IntPtr** and free the memory manually using the appropriate method. Similarly, you can avoid automatic memory freeing in situations where memory should never be freed, such as when using the **GetCommandLine** function from Kernel32.dll, which returns a pointer to kernel memory. For details on manually freeing memory, see the [Buffers Sample](http://msdn.microsoft.com/library/e30d36e8-d7c4-4936-916a-8fdbe4d9ffd5).  
+ The runtime always uses the **CoTaskMemFree** method to free memory. If the memory you are working with was not allocated with the **CoTaskMemAlloc** method, you must use an **IntPtr** and free the memory manually using the appropriate method. Similarly, you can avoid automatic memory freeing in situations where memory should never be freed, such as when using the **GetCommandLine** function from Kernel32.dll, which returns a pointer to kernel memory. For details on manually freeing memory, see the [Buffers Sample](https://msdn.microsoft.com/library/733c0dd2-12e5-46e6-8de1-39d5b25df024(v=vs.100)).  


This is the wrong URL. The correct one is https://msdn.microsoft.com/library/x3txb6xc(v=vs.100).aspx

rpetrusha · 2018-04-07T17:40:43Z

docs/framework/interop/marshaling-different-types-of-arrays.md

@@ -92,7 +88,7 @@ An array is a reference type in managed code that contains one or more elements
    int TestArrayOfStructs2 (MYPERSON* pPersonArray, int size);  
    ```  

- [PinvokeLib.dll](http://msdn.microsoft.com/library/5d1438d7-9946-489d-8ede-6c694a08f614) is a custom unmanaged library that contains implementations for the previously listed functions and two structure variables, **MYPOINT** and **MYPERSON**. The structures contain the following elements:  
+ [PinvokeLib.dll](https://msdn.microsoft.com/library/5d1438d7-9946-489d-8ede-6c694a08f614) is a custom unmanaged library that contains implementations for the previously listed functions and two structure variables, **MYPOINT** and **MYPERSON**. The structures contain the following elements:  


This needs to be https://msdn.microsoft.com/library/16014d9f-d6bd-481e-83f0-df11377c550f(v=vs.100)

BillWagner

Looks good. I only found a nit or two outside of Ron's comments.

BillWagner · 2018-04-09T17:52:04Z

docs/framework/interop/runtime-callable-wrapper.md


- ![RCW With Interfaces](../../../docs/framework/interop/media/rcwwithinterfaces.gif "rcwwithinterfaces")  
+ ![RCW With Interfaces](media/rcwwithinterfaces.gif "rcwwithinterfaces")  


Another instance of "media"

BillWagner · 2018-04-09T17:52:09Z

docs/framework/interop/runtime-callable-wrapper.md

@@ -28,7 +23,7 @@ The common language runtime exposes COM objects through a proxy called the runti

 The runtime creates exactly one RCW for each COM object, regardless of the number of references that exist on that object. The runtime maintains a single RCW per process for each object.  If you create an RCW in one application domain or apartment, and then pass a reference to another application domain or apartment, a proxy to the first object will be used.  As the following illustration shows, any number of managed clients can hold a reference to the COM objects that expose INew and INewer interfaces.  

- ![RCW](../../../docs/framework/interop/media/rcw.gif "rcw")  
+ ![RCW](media/rcw.gif "rcw")  


Earlier, you used "./media", and here "media".

Nit: we should be consistent.

mairaw · 2018-04-10T23:47:32Z

Thanks @BillWagner and @rpetrusha. I've addressed all your feedback.

mairaw added 3 commits April 6, 2018 10:52

update msdn links

5a07178

additional fixes

a30619b

last fixes

0e269c5

mairaw requested review from BillWagner and rpetrusha as code owners April 6, 2018 20:16

mairaw added 2 commits April 6, 2018 13:23

some adjustments

e8f4c43

fixes

0451d51

rpetrusha approved these changes Apr 7, 2018

View reviewed changes

BillWagner approved these changes Apr 9, 2018

View reviewed changes

feedback

78aead9

mairaw added verify-build-before-merge and removed verify-build-before-merge labels Apr 10, 2018

mairaw merged commit bf7dba6 into dotnet:master Apr 10, 2018

mairaw deleted the msdn-links branch April 10, 2018 23:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update msdn links and simplify relative links #4895

Update msdn links and simplify relative links #4895

Uh oh!

mairaw commented Apr 6, 2018 •

edited

Loading

Uh oh!

rpetrusha left a comment

Uh oh!

rpetrusha Apr 7, 2018

Uh oh!

mairaw Apr 9, 2018

Uh oh!

rpetrusha Apr 7, 2018

Uh oh!

rpetrusha Apr 7, 2018

Uh oh!

rpetrusha Apr 7, 2018

Uh oh!

BillWagner left a comment

Uh oh!

BillWagner Apr 9, 2018

Uh oh!

BillWagner Apr 9, 2018

Uh oh!

mairaw commented Apr 10, 2018

Uh oh!

Uh oh!


		![RCW With Interfaces](../../../docs/framework/interop/media/rcwwithinterfaces.gif "rcwwithinterfaces")
		![RCW With Interfaces](media/rcwwithinterfaces.gif "rcwwithinterfaces")

Update msdn links and simplify relative links #4895

Update msdn links and simplify relative links #4895

Uh oh!

Conversation

mairaw commented Apr 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rpetrusha left a comment

Choose a reason for hiding this comment

Uh oh!

rpetrusha Apr 7, 2018

Choose a reason for hiding this comment

Uh oh!

mairaw Apr 9, 2018

Choose a reason for hiding this comment

Uh oh!

rpetrusha Apr 7, 2018

Choose a reason for hiding this comment

Uh oh!

rpetrusha Apr 7, 2018

Choose a reason for hiding this comment

Uh oh!

rpetrusha Apr 7, 2018

Choose a reason for hiding this comment

Uh oh!

BillWagner left a comment

Choose a reason for hiding this comment

Uh oh!

BillWagner Apr 9, 2018

Choose a reason for hiding this comment

Uh oh!

BillWagner Apr 9, 2018

Choose a reason for hiding this comment

Uh oh!

mairaw commented Apr 10, 2018

Uh oh!

Uh oh!

mairaw commented Apr 6, 2018 •

edited

Loading