correcting tested method name to squaresOfOdds #4904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
BillWagner
approved these changes
Apr 11, 2018
There was a problem hiding this comment.
Thanks for working with us and fixing this issue @jurajplavcan We appreciate it.
I'll 
now, along with the updated samples.
You should see the updates on our next regular publish cycle. Thanks again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have also updated the test names in the code snippets. I'll open an issue and submit another PR in dotnet/samples repo to have the samples updated as well.
Note that I'm updating also the
squaresOfOddsmethod in the code snippets to return a sequence in xUnit and NUnit versions and it returns a list in MSTest version. This is how I found it in the sample projects in dotnet/samples repo. I think this difference is not an issue and it can show that there is often more than one way to solve a particular problem.Fixes #4902