ML.NET tutorials - bug fixes #5333
Conversation
|
|
||
| In Solution Explorer, right-click on your project and select **Manage NuGet Packages**. Choose "nuget.org" as the Package source, select the Browse tab, search for **Microsoft ML.NET**, select that package in the list, and select the **Install** button. If prompted to select a package management format, select **PackageReference in project file**. | ||
| In Solution Explorer, right-click on your project and select **Manage NuGet Packages**. Choose "nuget.org" as the Package source, select the Browse tab, search for **Microsoft.ML**, select that package in the list, and select the **Install** button. Select the **OK** button on the **Preview Changes** dialog and then select the **I Accept** button on the **License Acceptance** dialog if you agree with the license terms for the packages listed. |
There was a problem hiding this comment.
@mairaw it looks that using PackageReference is essential: dotnet/machinelearning#93
There was a problem hiding this comment.
@pkulikov Humm, if I follow the steps and add the reference, the package reference is added automatically for me. And even though my settings for NuGet are set as packages.config in VS, it correctly added to csproj file as expected. @eerhardt do you have more context on that issue Petr referenced above? How am I getting PackageReference by default? Is it because it's a .NET Core project?
There was a problem hiding this comment.
Yes, if you are using a .NET Core project, or any "SDK-based" project (<Project Sdk="Microsoft.NET.Sdk"> at the top of the .csproj), you get PackageReference by default. For classic .csproj files, you can set the default in VS Tools => Options => NuGet Package Manager => General
I'm working on a fix for dotnet/machinelearning#93, so that should be fixed in the next release.
There was a problem hiding this comment.
Thanks for confirming @eerhardt. So it's fine to remove that step since the tutorial is using a .NET Core app.
| @@ -273,4 +269,4 @@ In this tutorial, you learned how to: | |||
|
|
|||
| Check out our GitHub repository to continue learning and find more samples. | |||
| > [!div class="nextstepaction"] | |||
| > [GitHub Repository](https://github.com/dotnet/machinelearning/) | |||
| > [dotnet/machilearning GitHub repository](https://github.com/dotnet/machinelearning/) | |||
There was a problem hiding this comment.
type-o dotnet/machilearning => dotnet/machinelearning
mairaw
changed the title
mairaw
changed the title
mairaw
added
the
🚧 Hold for related PR
| @@ -110,35 +114,35 @@ public static PredictionModel<TaxiTrip, TaxiTripFarePrediction> Train() | |||
|
|
|||
| ## Create a learning pipeline | |||
|
|
|||
| Now create the learning pipeline. The learning pipeline loads all of the data and algorithms necessary to train the model. Copy the following code into the `Train()` method: | |||
| The learning pipeline loads all of the data and algorithms necessary to train the model. Add the following code into the `Train()` method: | |||
There was a problem hiding this comment.
@mairaw nit and question: methods should be mentioned without parenthesis?
So, not Train() but Train in the second sentence?
There was a problem hiding this comment.
Both are ok but I changed to the version without the parentheses to match how the other tutorial was using it.
|
|
||
| [!code-csharp[UsingTasks](../../../samples/machine-learning/tutorials/TaxiFarePrediction/Program.cs#9 "Add System.Threading.Tasks. to your usings.")] | ||
|
|
||
| Because the `async Main` method is a new feature in C# 7.1 and the default language version of the project is C# 7, you need to change the language version to C# 7.1 or higher. |
|
@JRAlexander I think this is ready for a final review. We need the samples changes merged for this PR to pass. |
|
Closing and reopening to restart failed build |
mairaw
removed
the
🚧 Hold for related PR
Fixes #5330
Fixes #5329
Fixes #5343
Fixes #5366
Fixes #5346
Companion PR: dotnet/samples#70
Main things addressed in this PR are:
Internal Review URL - Sentiment Analysis
Internal Review URL - Taxi Fare Predictor