-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add ArgumentNullException to AddProvider #7360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @maryamariyan Issue DetailsContributes to dotnet/docs#26780.
|
Docs Build status updates of commit 037d416: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
@@ -29,7 +29,7 @@ | |||
</Interface> | |||
</Interfaces> | |||
<Docs> | |||
<summary>Produces instances of <see cref="T:Microsoft.Extensions.Logging.ILogger" /> classes based on the given providers.</summary> | |||
<summary>Produces instances of <see cref="T:Microsoft.Extensions.Logging.ILogger" /> classes based on the specified providers.</summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gewarren @carlossanlop - for some reason I thought the triple-slash doc comments in dotnet/runtime were now the "master". Shouldn't we be updating them instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are not yet. We have only moved over 3 projects and we stopped because the porting tool has some issues. However we will try and make it the main story for .NET 7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the plan to port these changes to the triple-slash doc comments in the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should with the doc porting tool once that is ready.
* Update IConfiguration.xml Add a additional remark paragraph * Mention C# native integers in IntPtr/UIntPtr docs (#7364) * Update IntPtr.xml * Update UIntPtr.xml * Fixed identation (#7365) * Update xml/Microsoft.Extensions.Configuration/IConfiguration.xml The grammar is resolved Co-authored-by: Eric Erhardt <[email protected]> * Update obsoletion note in summary (#7359) * Update SecureString.xml (#7344) Obviously, those duplicate `SecureStringToCoTaskMemUnicode` should be `SecureStringToGlobalAllocUnicode` * Add exception (#7360) * add new exceptions (#7367) Co-authored-by: Artur <[email protected]> Co-authored-by: MSDN.WhiteKnight <[email protected]> Co-authored-by: Thiago Viana Avelar De Souza <[email protected]> Co-authored-by: Eric Erhardt <[email protected]> Co-authored-by: Genevieve Warren <[email protected]> Co-authored-by: tangentyh <[email protected]>
Contributes to dotnet/docs#26780.