[Exceptions] Simplify Types in Plain Text Representation #5017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tually implementing it
…o use the simplified versions for text
…ce - also found the bug that was causing multiple sets of [][]
…ve a bug with lots of foreign characters.
ghost
added
the
jander-msft
reviewed
Jul 28, 2023
src/Microsoft.Diagnostics.Monitoring.StartupHook/Exceptions/Eventing/ExceptionsEventSource.cs
Outdated
Show resolved
Hide resolved
kkeirstead
commented
Aug 1, 2023
jander-msft
reviewed
Aug 2, 2023
jander-msft
reviewed
Aug 2, 2023
jander-msft
reviewed
Aug 2, 2023
jander-msft
reviewed
Aug 4, 2023
jander-msft
reviewed
Aug 4, 2023
src/Microsoft.Diagnostics.Monitoring.WebApi/Stacks/NameFormatter.cs
Outdated
Show resolved
Hide resolved
jander-msft
reviewed
Aug 4, 2023
src/Microsoft.Diagnostics.Monitoring.WebApi/Models/CallStackResults.cs
Outdated
Show resolved
Hide resolved
jander-msft
approved these changes
Aug 11, 2023
wiktork
pushed a commit
to wiktork/dotnet-monitor
that referenced
this pull request
Jan 24, 2024
wiktork
added a commit
that referenced
this pull request
Jan 30, 2024
#5017) (#5882) * [Exceptions] Simplify Types in Plain Text Representation (#5017) * Fixup build errors * Fix unit tests * Fix name cache * Fix whitespace --------- Co-authored-by: kkeirstead <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jan 30, 2024
#5017) (#5882) * [Exceptions] Simplify Types in Plain Text Representation (#5017) * Fixup build errors * Fix unit tests * Fix name cache * Fix whitespace --------- Co-authored-by: kkeirstead <[email protected]>
wiktork
added a commit
that referenced
this pull request
Jan 30, 2024
#5017) (#5882) (#5920) * [Exceptions] Simplify Types in Plain Text Representation (#5017) * Fixup build errors * Fix unit tests * Fix name cache * Fix whitespace --------- Co-authored-by: Wiktor Kopec <[email protected]> Co-authored-by: kkeirstead <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In Plain Text, generic type args and method parameters are now trimmed to improve readability; the JSON format stays the same for machine readability. There are currently a few rough edges (one of which being the logic for getting the namespace in the profiler - if anyone has guidance there, let me know), so I'll likely be pushing some small changes before taking this out of draft.
Text (Before)
Text (After)
Closes #4714
Release Notes Entry