Add a relational model API #19896
Merged
Add a relational model API #19896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why not in query pipeline? 😢 |
Trying to keep the PR smaller |
AndriySvyryd
force-pushed
the
Issue12846
branch
from
d128173 to
f7f0d9a
Compare
bricelam
approved these changes
Feb 13, 2020
| if (!source.IsMigratable | ||
| || !target.IsMigratable) | ||
| { | ||
| yield break; |
There was a problem hiding this comment.
Probably worth adding extension methods like GetMigratableTables to filter these out earlier
There was a problem hiding this comment.
Also, this condition might be wrong. What if an entity type becomes (or stops being) migratable?
There was a problem hiding this comment.
That's why they are not filtered out early. This way if it becomes (or stops being) migratable migrations won't try to create or delete the table.
smitpatel
reviewed
Feb 13, 2020
smitpatel
reviewed
Feb 13, 2020
AndriySvyryd
force-pushed
the
Issue12846
branch
from
f7f0d9a to
4c63114
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new model in migrations and update pipeline
Part of #12846, #2725, #8258, #15671, #17270