Skip to content

[main] Update dependencies from dotnet/runtime #24824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[main] Update dependencies from dotnet/runtime #24824

wants to merge 3 commits into from

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented May 3, 2021 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: daf314a8-d8c8-4b54-8dcc-08d82e674dfc
  • Build: 20210503.3
  • Date Produced: 5/3/2021 4:37 PM
  • Commit: bb2d2c45410b9407a9657df7f5ca113bced53a43
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2021…
4a94325 
…0503.1

Microsoft.Extensions.Logging , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.HostFactoryResolver.Sources , System.Diagnostics.DiagnosticSource , System.Collections.Immutable
 From Version 6.0.0-preview.5.21226.1 -> To Version 6.0.0-preview.5.21253.1
@dotnet-maestro dotnet-maestro bot requested a review from dougbu as a code owner May 3, 2021 12:03
ghost
ghost approved these changes May 3, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@JunTaoLuo
Copy link
Contributor

Blocked on dotnet/runtime#52168.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2021…
c59802f 
…0503.3

Microsoft.Extensions.Logging , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.HostFactoryResolver.Sources , System.Diagnostics.DiagnosticSource , System.Collections.Immutable
 From Version 6.0.0-preview.5.21226.1 -> To Version 6.0.0-preview.5.21253.3
@JunTaoLuo
Copy link
Contributor

Looks like I mis-diagnosed the issue. I'll take a closer look.

@JunTaoLuo
Copy link
Contributor

I can't really make heads or tails of how the test failures were related to the runtime updates. But I've seen a quite a few fixes go in in dotnet/runtime so I'm triggering a subscription update. Let's see how the latest runtime affects the failures.

@lewing lewing mentioned this pull request May 5, 2021
Merged
@marek-safar
Copy link

@eerhardt it looks like some of the recent ME fixes broke EF. Could you investigate it?

@eerhardt
Copy link
Member

eerhardt commented May 5, 2021

@davidfowl - these test failures all look like they are caused by your recent DI changes.

@TanayParikh
Copy link
Contributor

@davidfowl - these test failures all look like they are caused by your recent DI changes.

/ping @davidfowl

@davidfowl
Copy link
Member

All the DI bugs

@davidfowl davidfowl mentioned this pull request May 8, 2021
Merged
@davidfowl
Copy link
Member

The fix is in PR here dotnet/runtime#52484

@dotnet-maestro dotnet-maestro bot deleted the darc-main-db342341-b162-409a-8978-f659eca4e004 branch May 8, 2021 19:37
@lewing lewing restored the darc-main-db342341-b162-409a-8978-f659eca4e004 branch May 8, 2021 21:09
@lewing lewing reopened this May 8, 2021
@dougbu
Copy link
Contributor

dougbu commented May 8, 2021

@lewing why reopen this PR❔ #24860 moves the dependencies forward enough to get most of the dotnet/runtime fixes.

@davidfowl
Copy link
Member

I thought these dependency update PRs update in place?

@lewing
Copy link
Member

lewing commented May 8, 2021 •
edited
Loading

@dougbu that wasn't there when I started reopening and I noticed there wasn't an update, we can close it in favor of #24860 I don't have a strong preference. I just noticed this had been closed without an actual update because of the comment in the runtime pr.

@lewing
Copy link
Member

lewing commented May 8, 2021

I thought these dependency update PRs update in place?

They do usually, this one got automatically closed in dotnet/runtime#52484 by accident so I reopened, apparently the bot had also started a new flow at roughly the same time.

@davidfowl
Copy link
Member

Oops it because I put "fixes" lol 😆

@dougbu dougbu mentioned this pull request May 8, 2021
Closed
@dougbu
Copy link
Contributor

dougbu commented May 8, 2021

apparently the bot had also started a new flow at roughly the same time.

I triggered the subscription and the bot created #24860 before you reopened this one. I'll close #24860 because it lacks the context in this PR and isn't working anyway.

I'll retrigger the subscription in a couple of hours.

@dougbu dougbu mentioned this pull request May 8, 2021
Merged
@dougbu
Copy link
Contributor

dougbu commented May 8, 2021

Closing because the bot is insistent. See #24861

@dougbu dougbu closed this May 8, 2021
@dougbu dougbu deleted the darc-main-db342341-b162-409a-8978-f659eca4e004 branch May 8, 2021 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu Awaiting requested review from dougbu

1 more reviewer
Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area-infrastructure blocked type-dependency update 🔼
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@JunTaoLuo @marek-safar @eerhardt @TanayParikh @davidfowl @dougbu @lewing @Tratcher